Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "user_was_notified_of_alert_groups" metric #2334

Merged
merged 14 commits into from
Jun 28, 2023
Merged

Add "user_was_notified_of_alert_groups" metric #2334

merged 14 commits into from
Jun 28, 2023

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Jun 26, 2023 •
edited
Loading

This PR adds new metric for Prometheus exporter "user_was_notified_of_alert_groups" which counts how many alert groups user was notified of.

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@Ferril Ferril marked this pull request as ready for review June 26, 2023 13:19
@Ferril Ferril requested review from a team and matiasb June 26, 2023 13:19
Ferril added 3 commits June 26, 2023 16:19
@Ferril
Add "user_was_notified_of_alert_groups" metric
6a2f248 
- Add cache update on user notification
- Add metric calculation task
- Add user_was_notified_of_alert_groups metric to metrics collector
@Ferril
Add tests for
3ddbc8c
@Ferril
Update docs
38bb682
@Ferril Ferril force-pushed the add_user_was_notified_metric branch from 57db3f2 to 38bb682 Compare June 26, 2023 14:19
matiasb
matiasb reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, added a few questions/comments.

engine/apps/alerts/tasks/notify_user.py Show resolved Hide resolved
engine/apps/metrics_exporter/metrics_collectors.py Outdated Show resolved Hide resolved
engine/apps/metrics_exporter/tasks.py Outdated Show resolved Hide resolved
matiasb
matiasb approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine/apps/metrics_exporter/tasks.py Show resolved Hide resolved
@Ferril Ferril added this pull request to the merge queue Jun 28, 2023
Merged via the queue into dev with commit f1fcb41 Jun 28, 2023
@Ferril Ferril deleted the add_user_was_notified_metric branch June 28, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando left review comments

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferril @matiasb @joeyorlando